-
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: Airflow Listener integration #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 39 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
5033d79
mount listener volumes for relevant roles, type depending on listener…
adwk67 3bbe747
merge main
adwk67 7e8456a
add podrefs to write webserver endpoint to configmap
adwk67 7d67a6b
moved listener-class to webserver role
adwk67 f4c6fd7
Merge branch 'main' into feat/integrate-listener-operator
adwk67 6c2e2b3
move config map creation out of role-loop
adwk67 56dc940
Merge branch 'main' into feat/integrate-listener-operator
adwk67 f250059
merge conflicts
adwk67 48ae7e3
Merge branch 'main' into feat/integrate-listener-operator
adwk67 b6b969e
regenerate nix
adwk67 5e7b41b
assign listener-class to all roles and consider all ports
adwk67 8706a3e
fixed podref name for workers
adwk67 07efc9f
added integration test
adwk67 87a1295
changelog
adwk67 e646700
added docs
adwk67 77bcb82
Merge branch 'main' into feat/integrate-listener-operator
adwk67 64175f3
Update rust/operator-binary/src/crd/mod.rs
adwk67 7837af3
Update rust/operator-binary/src/crd/mod.rs
adwk67 6b359d1
Update rust/operator-binary/src/crd/mod.rs
adwk67 ebe8079
Update rust/operator-binary/src/crd/mod.rs
adwk67 acbca3e
corrected callout comments and regenerate charts
adwk67 8270343
Merge branch 'main' into feat/integrate-listener-operator
adwk67 8ae3303
use ephemeral listeners classes; fix test missing dimension
adwk67 f4ecd43
allow config map endpoints to be removed if cluster is stopped
adwk67 5c7022c
review feedback
adwk67 1003da2
check for port lower-bound
adwk67 8f0e539
Merge branch 'main' into feat/integrate-listener-operator
adwk67 dc803f4
reworked to only offer listener for webserver role
adwk67 a4ec801
reworked docs
adwk67 8beab3e
merge main
adwk67 063bded
Update docs/modules/airflow/pages/usage-guide/listenerclass.adoc
adwk67 25ce160
Update rust/operator-binary/src/crd/mod.rs
adwk67 0095ad9
added service check to test
adwk67 7da421c
correctly flatten WebserverConfig
adwk67 7ac6077
use pvcs for externally reachable endpoints
adwk67 0f650d3
use group listener for webservers
adwk67 7dcff05
Merge branch 'main' into feat/integrate-listener-operator
adwk67 dcc21f9
replace enum with string; use consistent webserver address for all li…
adwk67 3d2f3e0
removed unused test account
adwk67 95597e3
Update docs/modules/airflow/pages/usage-guide/listenerclass.adoc
adwk67 06e44af
Update tests/templates/kuttl/opa/41_check-authorization.py
adwk67 2a6313e
Update tests/templates/kuttl/oidc/login.py
adwk67 f9c41bc
review feedback: tests
adwk67 cb85a6a
review feedback: remove metrics port and re-work conditions
adwk67 57e1644
use custom listeners to stay independent of future changes to standar…
adwk67 ea88ae4
make custom listener classes namespace-specific
adwk67 f0b5b30
changes as per decision 51
adwk67 0cdd328
Merge branch 'main' into feat/integrate-listener-operator
adwk67 02cc5c7
fixed tests
adwk67 ccfd545
Merge branch 'main' into feat/integrate-listener-operator
adwk67 8bfaafb
Merge branch 'main' into feat/integrate-listener-operator
adwk67 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 11 additions & 10 deletions
21
docs/modules/airflow/pages/usage-guide/listenerclass.adoc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,19 @@ | ||
| = Service exposition with ListenerClasses | ||
| :description: Configure Airflow service exposure with ListenerClasses: cluster-internal, external-unstable, or external-stable. | ||
|
|
||
| Airflow offers a web UI and an API, both are exposed by the webserver process under the `webserver` role. | ||
| The Operator deploys a service called `<name>-webserver` (where `<name>` is the name of the AirflowCluster) through which Airflow can be reached. | ||
|
|
||
| This service can have three different types: `cluster-internal`, `external-unstable` and `external-stable`. | ||
| Read more about the types in the xref:concepts:service-exposition.adoc[service exposition] documentation at platform level. | ||
|
|
||
| This is how the listener class is configured: | ||
| The operator deploys a xref:listener-operator:listener.adoc[Listener] for the Webserver pod. | ||
| The listener defaults to only being accessible from within the Kubernetes cluster, but this can be changed by setting `.spec.webservers.config.listenerClass`: | ||
|
|
||
| [source,yaml] | ||
| ---- | ||
| spec: | ||
| clusterConfig: | ||
| listenerClass: cluster-internal # <1> | ||
| webservers: | ||
| config: | ||
| listenerClass: external-unstable # <1> | ||
| schedulers: | ||
| ... | ||
| celeryExecutors: | ||
| ... | ||
| ---- | ||
| <1> The default `cluster-internal` setting. | ||
| <1> Specify one of `external-stable`, `external-unstable`, `cluster-internal` (the default setting is `cluster-internal`). | ||
| This can be set only for the webservers role. | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.