Linear algebra: Expose the remaining classes listed in Eigen documentation (decompositions and solvers) #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucas-Haubert
changed the title
Lucas-Haubert
changed the title
23 tasks
jcarpent
force-pushed
the
topic/linear_algebra
branch
from
7848bd8 to
08cc3d0
Compare
…d put MINRES in capital letters
Lucas-Haubert
force-pushed
the
topic/linear_algebra
branch
from
0d3a259 to
bede0bf
Compare
Lucas-Haubert
force-pushed
the
topic/linear_algebra
branch
from
1c58d59 to
f401316
Compare
jorisv
requested changes
Jul 24, 2025
jorisv
reviewed
Jul 24, 2025
| +[](QTransposeType& self, const VectorXd& other) -> VectorXd { | ||
| return VectorXd(self * other); | ||
| }, | ||
| bp::args("self", "other")); |
There was a problem hiding this comment.
Can we convert the SparseQRMatrixQTransposeReturnTypeVisitor (and all other view) to a generic sparse matrix ?
There was a problem hiding this comment.
Yes, but even when the source code refers to the same intermediate class (as a return type) (struct SparseQRMatrixQTransposeReturnType).
For other views, they concern SparseLU.hpp and contain solveInPlace methods.
…ER following pinocchio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (draft) PR aims at adding the remaining classes in Eigen that we plan to use in practice.
This PR is proposed jointly with the one in nanoeigenpy (Simple-Robotics/nanoeigenpy#13).
What follows if the list of classes treated in this work:
<Eigen/LU>:FullPivLU<Eigen/LU>:PartialPivLU<Eigen/SVD>:JacobiSVD<Eigen/SVD>:BDCSVD<Eigen/Eigenvalues>:ComplexEigenSolver<Eigen/Eigenvalues>:GeneralizedEigenSolver<Eigen/Eigenvalues>:GeneralizedSelfAdjointSolver<Eigen/Eigenvalues>:HessenbergDecomposition<Eigen/Eigenvalues>:RealQZ<Eigen/Eigenvalues>:RealSchur<Eigen/Eigenvalues>:ComplexSchur<Eigen/Eigenvalues>:Tridiagonalization<Eigen/SparseLU>:SparseLU<Eigen/SparseQR>:SparseQR<Eigen/IterativeLinearSolvers>:BiCGSTAB<Eigen/IterativeLinearSolvers>:IncompleteLUT<Eigen/IterativeLinearSolvers>:IncompleteCholesky