-
Notifications
You must be signed in to change notification settings - Fork 27
Proxy asset HREFs #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Proxy asset HREFs #991
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
bb06d9b
feat: initial, untested implementation
pjhartzell 83cdb90
tests: WIP, not all running
pjhartzell c969b9c
refactor: second iteration of initial implementation
pjhartzell 4237b52
refactor: use app.local state, sundry fixups, working tests
pjhartzell e4b1c2a
docs: update openapi.yaml to reflect asset proxy endpoints
pjhartzell b0ae7d5
docs: update README
pjhartzell a09d37a
chore: update CHANGELOG
pjhartzell ac302f9
review: move appInstance initialization out of function scope so it o…
pjhartzell 4802a72
review: initialize assetProxy outside function so it runs during lamb…
pjhartzell 40632c8
review: move from v2 to v3 of AWS SDK
pjhartzell b76f0e4
review: remove unnecessary S3 client caching in AssetProxy
pjhartzell 8d3c10f
review: 403 t0 404 when asset proxy is disabled
pjhartzell dad9234
review: remove redundant asset proxy isEnabled check
pjhartzell f8ae55e
review: significant refactor to improve bucket caching and region det…
pjhartzell 9dc923f
docs: update docs
pjhartzell 517a5d4
docs: minor README update and logging improvement in asset-proxy.js
pjhartzell 3e96a02
review: remove commented code
pjhartzell 3dec688
review: pull asset proxy bucket management into its own class
pjhartzell 1126949
chore: update CHANGELOG
pjhartzell cad05dc
refactor: extract AssetBuckets class from asset-proxy.js
pjhartzell 6863bad
review: correct requester pay information in README
pjhartzell eab7890
fix: correct errors revealed by testing a deployment
pjhartzell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.