Add filter extension

src/lib/api.js

@@ -1017,13 +1017,25 @@ const getGlobalQueryables = async (endpoint = '') => ({
   additionalProperties: true
 })
 
+const validateAdditionalProperties = (queryables) => {
+  if ('additionalProperties' in queryables) {
+    const additionalProperties = queryables.additionalProperties
+    if (additionalProperties !== true) {
+      throw new ValidationError(
+        `Unsupported additionalProperties value: "${additionalProperties}". Must be set to "true".`
+      )
+    }
+  }
+}
+
 const getCollectionQueryables = async (collectionId, backend, endpoint = '') => {
   const collection = await backend.getCollection(collectionId)
 
   if (collection instanceof Error) {
     return collection
   }
   const queryables = collection.queryables || { ...DEFAULT_QUERYABLES }
+  validateAdditionalProperties(queryables)
   queryables.$id = `${endpoint}/collections/${collectionId}/queryables`
   queryables.title = `Queryables for Collection ${collectionId}`
   return queryables

tests/fixtures/stac/collection-with-incorrect-queryables.json

@@ -0,0 +1,41 @@
+{
+    "id": "landsat-8-l1-incorrect-queryables",
+    "type": "Collection",
+    "stac_version": "1.0.0",
+    "description": "Landat-8 L1 Collection-1 imagery radiometrically calibrated and orthorectified using gound points and Digital Elevation Model (DEM) data to correct relief displacement.",
+    "links": [],
+    "stac_extensions": [],
+    "title": "Landsat-8 L1 Collection-1",
+    "extent": {
+        "spatial": {
+            "bbox": [
+                [
+                    -180,
+                    -90,
+                    180,
+                    90
+                ]
+            ]
+        },
+        "temporal": {
+            "interval": [
+                [
+                    "2013-06-01T00:00:00Z",
+                    null
+                ]
+            ]
+        }
+    },
+    "queryables": {
+        "$schema": "https://json-schema.org/draft/2020-12/schema",
+        "$id": "",
+        "type": "object",
+        "title": "",
+        "properties": {
+            "eo:cloud_cover": {
+                "$ref": "https://stac-extensions.github.io/eo/v1.0.0/schema.json#/definitions/fields/properties/eo:cloud_cover"
+            }
+        },
+        "additionalProperties": false
+    }
+}

tests/system/test-api-get-collection-queryables.js

@@ -87,3 +87,27 @@ test('GET /collection/:collectionId/queryables for non-existent collection retur
 
   t.is(response.statusCode, 404)
 })
+
+test.only('GET /collection/:collectionId/queryables for collection with unsupported queryables fails', async (t) => {
+  const collection = await loadFixture(
+    'stac/collection-with-incorrect-queryables.json',
+    { id: t.context.collectionId }
+  )
+
+  await ingestItem({
+    ingestQueueUrl: t.context.ingestQueueUrl,
+    ingestTopicArn: t.context.ingestTopicArn,
+    item: collection
+  })
+
+  const { collectionId } = t.context
+
+  const error = await t.throwsAsync(
+    async () => t.context.api.client.get(`collections/${collectionId}/queryables`,
+      { resolveBodyOnly: false })
+  )
+
+  t.is(error.response.statusCode, 400)
+  t.regex(error.response.body.description,
+    /.*Unsupported additionalProperties value: "false". Must be set to "true".*/)
+})