Skip to content

allow configuration of CORS origin #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2024
Merged

allow configuration of CORS origin #764

merged 5 commits into from
May 14, 2024

Conversation

philvarner
Copy link
Collaborator

@philvarner philvarner commented May 10, 2024 •
edited
Loading

Related Issue(s):

  • n/a

Proposed Changes:

  1. Add configuration parameters for CORS, so headers can be set correctly to allow restriction of server to specific UI URLs and allow credentials to be passed.

PR Checklist:

  • I have added my changes to the CHANGELOG or a CHANGELOG entry is not required.

@philvarner philvarner marked this pull request as ready for review May 14, 2024 01:04
@philvarner philvarner requested review from gadomski and ircwaves May 14, 2024 13:02
ircwaves
ircwaves approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@ircwaves ircwaves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That table's begging me to port it to something with line wrapping, but otherwise looks good.

@philvarner philvarner merged commit d6efedd into main May 14, 2024
3 checks passed
@philvarner philvarner deleted the pv/cors-config branch May 14, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ircwaves ircwaves ircwaves approved these changes

@gadomski gadomski Awaiting requested review from gadomski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philvarner @ircwaves