Skip to content

fix: remove root path prefix when root_path is set on app #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 22, 2025
Merged

fix: remove root path prefix when root_path is set on app #270

merged 8 commits into from
Jul 22, 2025
+132 −12

Conversation

alukach
Copy link
Collaborator

@alukach alukach commented Jul 20, 2025 •
edited
Loading

Related Issue(s):

Description:

See #262 (comment)

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@alukach alukach force-pushed the bugfix/262/duplicate-root-path branch from db9f270 to 98d6488 Compare July 20, 2025 04:52
@alukach alukach force-pushed the bugfix/262/duplicate-root-path branch from d43398c to 92bd06f Compare July 20, 2025 05:48
@alukach alukach mentioned this pull request Jul 20, 2025
Closed
@alukach alukach force-pushed the bugfix/262/duplicate-root-path branch from e0e7707 to b466a3b Compare July 20, 2025 07:05
@alukach alukach marked this pull request as ready for review July 21, 2025 16:16
@alukach alukach requested a review from vincentsarago July 21, 2025 17:03
vincentsarago
vincentsarago reviewed Jul 22, 2025
View reviewed changes
@vincentsarago vincentsarago self-requested a review July 22, 2025 17:07
vincentsarago
vincentsarago approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally with ROOT_PATH and with unicorn --root-path=/api/v1/pgstac and everything works fine 👍

@alukach alukach merged commit baac642 into main Jul 22, 2025
7 checks passed
@alukach alukach deleted the bugfix/262/duplicate-root-path branch July 22, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentsarago vincentsarago vincentsarago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alukach @vincentsarago