-
Notifications
You must be signed in to change notification settings - Fork 24
Create shared sfeos helpers module #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This will be a difficult pr to review maybe?
|
50 files changed so yes, difficult to review :) |
This is a great change. Maintaining the duplicate code was getting cumbersome. I'll dig into this PR over the weekend 👍 |
Still a lot of duplicate code, but it's a start hopefully that will help improve maintenance and also keep the core module database agnostic. |
Sharing too much code could be troublesome in the future as well as the two projects diverge more from each other. |
Related Issue(s):
Description:
core
and into thesfeos_helpers
module.database_logic
files has been moved into thesfeos_helpers
module as well.PR Checklist:
pre-commit run --all-files
)make test
)