Skip to content

MLM bugfixes #1556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

MLM bugfixes #1556

wants to merge 73 commits into from

Conversation

jonas-hurst
Copy link
Contributor

@jonas-hurst jonas-hurst commented May 2, 2025

**Description:
Fixed some bugs in mlm extension (see changelog for details)

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@jonas-hurst
Copy link
Contributor Author

I continued working on my (synced) fork, so this PR also lists commits that have already been merged a few weeks ago... Sorry for the mess...

Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 98.53480% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.55%. Comparing base (fa00c5d) to head (df2ef7f).

Files with missing lines Patch % Lines
pystac/extensions/mlm.py 98.52% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1556      +/-   ##
==========================================
+ Coverage   92.42%   92.55%   +0.13%     
==========================================
  Files          55       55              
  Lines        8368     8569     +201     
  Branches      963     1035      +72     
==========================================
+ Hits         7734     7931     +197     
- Misses        449      450       +1     
- Partials      185      188       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gadomski gadomski self-requested a review May 5, 2025 12:28
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution and fixes! I can review the code, but I don't have much visibility into how the MLM extension works. Could you possibly suggest two or three folks that might be able to review this PR from for content and usability?

@jsignell
Copy link
Member

It might also make sense to cherry-pick the new commits onto a fresh branch off origin:main so that the diff is easier to parse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants