-
Notifications
You must be signed in to change notification settings - Fork 123
MLM bugfixes #1556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
MLM bugfixes #1556
Conversation
…, percentage, count
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
I continued working on my (synced) fork, so this PR also lists commits that have already been merged a few weeks ago... Sorry for the mess... |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
==========================================
+ Coverage 92.42% 92.55% +0.13%
==========================================
Files 55 55
Lines 8368 8569 +201
Branches 963 1035 +72
==========================================
+ Hits 7734 7931 +197
- Misses 449 450 +1
- Partials 185 188 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution and fixes! I can review the code, but I don't have much visibility into how the MLM extension works. Could you possibly suggest two or three folks that might be able to review this PR from for content and usability?
It might also make sense to cherry-pick the new commits onto a fresh branch off origin:main so that the diff is easier to parse. |
**Description:
Fixed some bugs in mlm extension (see changelog for details)
PR Checklist:
pre-commit run --all-files
)pytest
)