Skip to content

Coerce cql2 style to match HTTP method #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 15, 2025

Conversation

jsignell
Copy link
Member

Related Issue(s):

Description:

Coerced the filter value to cql2-json for POST and cql2-text for GET unless the user specifies the filter-lang.

This uses cql2-rs python bindings and adds cql2 as a dev dependency, but it fails with a nice error message if that library is not in the env.

PR Checklist:

  • Code is formatted
  • Tests pass
  • Changes are added to CHANGELOG.md

@gadomski gadomski self-requested a review July 10, 2025 18:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.99%. Comparing base (21435b0) to head (1af0f93).
Report is 125 commits behind head on main.

Files with missing lines Patch % Lines
pystac_client/item_search.py 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
+ Coverage   93.43%   93.99%   +0.55%     
==========================================
  Files          13       15       +2     
  Lines         990     1232     +242     
==========================================
+ Hits          925     1158     +233     
- Misses         65       74       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jsignell
Copy link
Member Author

Looks like the failures are related to this: actions/runner-images#12576

@jsignell jsignell enabled auto-merge (squash) July 15, 2025 20:16
@jsignell jsignell merged commit b418a57 into stac-utils:main Jul 15, 2025
13 checks passed
@jsignell jsignell deleted the filter_coersion branch July 15, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter CQL2 style needs to match HTTP method in search
3 participants