Adding steps to pypi workflow - bot commit version bump #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding two extra steps to commit version bump to pyproject
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #588 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 29 29
Lines 1865 1865
=======================================
Hits 1794 1794
Misses 71 71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gordonwatts
reviewed
May 12, 2025
There was a problem hiding this comment.
These changes look good to me. I'd like Ben or Peter to also comment to make sure we all know what is going on in this logic. I don't think most of us are used to auto-updating packages during a release. I like it, because now when you check it out you get the right version in your code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a couple of steps in
pypi.ymlto commit the version bump when a release is created.I also changed the version tag replacement using
sed.There was an extra white space being introduced. This would cause the reggex search to fail on the next release event.
This should fix the doc building issue (currently showing the wrong release tag) automaticaly for next releases.
This garantees
pyproject.tomlin master is consistent with the distributed package tag.I also manualy set the version to 3.1.1 since that release is published.
Tested with pre-releases on the feat/version-bump-gha branch, and the github bot correctly comits the version bump.