-
Notifications
You must be signed in to change notification settings - Fork 13
Upgrade to pydantic2 #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to pydantic2 #368
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0_develop #368 +/- ##
===============================================
+ Coverage 73.78% 73.88% +0.10%
===============================================
Files 42 42
Lines 2300 2305 +5
===============================================
+ Hits 1697 1703 +6
+ Misses 603 602 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Resolves #363 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working nicely!
Once this is merged in, can a |
@matthewfeickert - if you are referring to the ServiceX client version in the ATLAS idap repo that's still in the another branch ( |
More broadly than the repo but iris-hep/idap-200gbps-atlas#60 in general with the servicex client getting added to the install list in https://github.com/usatlas/analysisbase-dask.
I guess I'm confused about how development is done here, but that branch is a separate feature request, 3.0_develop...3.0_develop_uprootraw ,so why isn't that branch just rebased off of |
Thanks @BenGalewsky, for the great PR and for merging this in! @kyungeonchoi I'm sorry earlier for writing a note hastily and without proper clarity. I didn't mean to suggest that a alpha release be cut from the
to mean that you were waiting on I can't promise that I'll be at the Friday 2024-05-03 meeting, but if the |
Background
Pydantic V2 is a ground-up rewrite that offers many new features, performance improvements, and some breaking changes compared to Pydantic V1. The main reasons for the changes include: