Skip to content

build: Update typer lower bound to v0.12.1 #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

matthewfeickert
Copy link
Member

This is a component PR on the way towards targeting Issue #363, which is needed for full integration in the IDAP pipelines.

  • In typer v0.12.1 the 'all' extra is dropped as all required dependencies are provided as typer installs the 'standard' extra by default.
  • The increase in version number only increases the lower bound on the click dependency and removes multiple upper bounds on other dependencies, making it easier to support the newer release.

* In typer v0.12.1 the 'all' extra is dropped as all required dependencies
  are provided as typer installs the 'standard' extra by default.
   - c.f. https://github.com/tiangolo/typer/releases/tag/0.12.1
* The increase in version number only increases the lower bound on the click
  dependency and removes multiple upper bounds on other dependencies, making
  it easier to support the newer release.
   - c.f. fastapi/typer@0.9.1...0.12.1
@matthewfeickert
Copy link
Member Author

@gordonwatts @BenGalewsky @ponyisi This is ready for review.

@BenGalewsky BenGalewsky self-requested a review May 1, 2024 16:05
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible improvement. Thank you @matthewfeickert

@BenGalewsky BenGalewsky merged commit ae0ff0d into ssl-hep:3.0_develop May 1, 2024
16 checks passed
@matthewfeickert matthewfeickert deleted the feat/update-typer-dependency branch May 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants