Multiple xrootdfiles #359
Merged
Multiple xrootdfiles #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenGalewsky
requested review from
gordonwatts and
kyungeonchoi
and removed request for
gordonwatts
BenGalewsky
force-pushed
the
multiple_xrootdfiles
branch
from
d72b90b to
07a8579
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.0_develop #359 +/- ##
===============================================
- Coverage 79.89% 72.28% -7.62%
===============================================
Files 41 41
Lines 2253 2226 -27
===============================================
- Hits 1800 1609 -191
- Misses 453 617 +164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Pydantic 3.0 client doesn't accept multiple root file paths. It only supports a single root file.
Approach
Changed the name of the property from
XRootdFiletoXRootDFilesand allow it to be a string or a list of strings. Note that the case changed on this too.Need to start testing more of this functionality out, so I updated test_databinder as a start