Skip to content

Re-introduce ChangeWindow method on ShellStream #1646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 25, 2025

Conversation

Rasmus715
Copy link
Contributor

@Rasmus715 Rasmus715 commented May 22, 2025

Due to stale state of #1062, I've decided to carry the feature by myself.

All the necessary suggestions from the initial PR were applied.

closes #1061
closes #1252
closes #1062
closes #1514
closes #40

Let's make this PR to the main branch. I desperately need this feature

@Rasmus715
Copy link
Contributor Author

Pipeline fails due not to my changes. I'll fix it as well.

etozherasmus and others added 3 commits May 23, 2025 14:27
Co-authored-by: Glen Kleidon <glenk@galkam.com.au>
Co-authored-by: oheiheiheiheihei <294797392@qq.com>
Copy link
Collaborator

@Rob-Hague Rob-Hague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have added contribution credit to @glenkleidon and @294797392 for their previous efforts.

@Rob-Hague Rob-Hague merged commit 4fcf604 into sshnet:develop May 25, 2025
@Rasmus715
Copy link
Contributor Author

Rasmus715 commented May 26, 2025

Thank you for a quick response!
Is there a way to put NuGet with this change as a prerelease one?

@Rob-Hague
Copy link
Collaborator

You can use the GH feed: https://github.com/sshnet/SSH.NET#using-pre-release-nuget-packages

There probably won't be one on nuget.org for a while

@Rasmus715 Rasmus715 deleted the features/change-window-size branch June 25, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants