Introduces Activity.workflowContentView, workflowContentViewOrNull #1336
+82
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
commented
Jun 6, 2025
| @@ -125,7 +120,7 @@ class PerformancePoetryActivity : AppCompatActivity() { | |||
| val traceMain = intent.getBooleanExtra(EXTRA_TRACE_ALL_MAIN_THREAD_MESSAGES, false) | |||
| val traceSelectOnTimeout = intent.getBooleanExtra(EXTRA_TRACE_SELECT_TIMEOUTS, false) | |||
| val areTracingViaMainLooperCurrently = traceMain || traceSelectOnTimeout | |||
| val ableToTrace = Build.VERSION.SDK_INT != 28 && (debuggable || profileable) | |||
| val ableToTrace = debuggable || profileable | |||
There was a problem hiding this comment.
IDE called out the 28 check as redundant b/c our min SDK is now 29
Simplifies creating a `WorkflowLayout` and using it as the `contentView` of an `Activity`. Written with an eye toward making it easy to hand off from one workflow runtime to another, or doing something like `activity.workflowContentView.show(LoadingScreen)` before any workflow runtime is put in place. Nice for testing too.
|
Oops, botched a couple of test updates. Easy fixes. |
|
Oh no! Putting this back to draft status while I dig in to this. |
Bah. It's a flake at the command line, and I didn't touch any code related to this test ( |
rjrjr
force-pushed
the
ray/activity-workflowContentView
branch
from
941413a to
de3966d
Compare
wardellbagby
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies creating a
WorkflowLayoutand using it as thecontentViewof anActivity. Written with an eye toward making it easy to hand off from one workflow runtime to another, or doing something likeactivity.workflowContentView.show(LoadingScreen)before any workflow runtime is put in place.