Skip to content

Conversation

@handstandsam
Copy link
Collaborator

@handstandsam handstandsam commented May 7, 2025

  1. We weren't actually updating the extras appropriately. (Didn't make the Map mutable and add to it)
  2. We we would have only used the module's owner, but now if a code reference specifies an owner, it will use that override.
{
    "metadata": {
        "key": "android_tests",
        "description": "Android @Test(s)",
        "dataType": "CODE_REFERENCES",
        "category": "Android Tests",
        "extras": [
            {
                "key": "module",
                "type": "STRING",
                "description": "Module"
            },
            {
                "key": "owner",
                "type": "STRING",
                "description": "Owner"
            }
        ]
    },
    "values": [
        {
            "filePath": "apps/somemodule/src/main/SomeTest.kt",
            "startLine": 78,
            "endLine": 99,
            "extras": {
                "module": ":somemodule",
                "owner": "SomeOwner"
            },
            "code": "...",
        },
    ]
}

@handstandsam handstandsam merged commit 4eba430 into main May 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant