Skip to content

SQLite: Fix convertion of UPDATE statements table name #4013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions internal/endtoend/testdata/update_set/sqlite/go/query.sql.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions internal/endtoend/testdata/update_set/sqlite/query.sql
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
/* name: UpdateSet :exec */
UPDATE foo SET name = ? WHERE slug = ?;

/* name: UpdateSetQuoted :exec */
UPDATE "foo" SET "name" = ? WHERE "slug" = ?;
96 changes: 57 additions & 39 deletions internal/engine/sqlite/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -1021,6 +1021,8 @@ func (c *cc) convertTablesOrSubquery(n []parser.ITable_or_subqueryContext) []ast
}

type Update_stmt interface {
node

Qualified_table_name() parser.IQualified_table_nameContext
GetStart() antlr.Token
AllColumn_name() []parser.IColumn_nameContext
Expand All @@ -1034,50 +1036,66 @@ func (c *cc) convertUpdate_stmtContext(n Update_stmt) ast.Node {
return nil
}

relations := &ast.List{}
tableName := n.Qualified_table_name().GetText()
rel := ast.RangeVar{
Relname: &tableName,
Location: n.GetStart().GetStart(),
}
relations.Items = append(relations.Items, &rel)
if qualifiedName, ok := n.Qualified_table_name().(*parser.Qualified_table_nameContext); ok {
tableName := identifier(qualifiedName.Table_name().GetText())
rel := ast.RangeVar{
Relname: &tableName,
Location: n.GetStart().GetStart(),
}

list := &ast.List{}
for i, col := range n.AllColumn_name() {
colName := identifier(col.GetText())
target := &ast.ResTarget{
Name: &colName,
Val: c.convert(n.Expr(i)),
if qualifiedName.Schema_name() != nil {
schemaName := qualifiedName.Schema_name().GetText()
rel.Schemaname = &schemaName
}
list.Items = append(list.Items, target)
}

var where ast.Node = nil
if n.WHERE_() != nil {
where = c.convert(n.Expr(len(n.AllExpr()) - 1))
}
if qualifiedName.Alias() != nil {
alias := qualifiedName.Alias().GetText()
rel.Alias = &ast.Alias{Aliasname: &alias}
}

stmt := &ast.UpdateStmt{
Relations: relations,
TargetList: list,
WhereClause: where,
FromClause: &ast.List{},
WithClause: nil, // TODO: support with clause
}
if n, ok := n.(interface {
Returning_clause() parser.IReturning_clauseContext
}); ok {
stmt.ReturningList = c.convertReturning_caluseContext(n.Returning_clause())
} else {
stmt.ReturningList = c.convertReturning_caluseContext(nil)
}
if n, ok := n.(interface {
Limit_stmt() parser.ILimit_stmtContext
}); ok {
limitCount, _ := c.convertLimit_stmtContext(n.Limit_stmt())
stmt.LimitCount = limitCount
relations := &ast.List{}

relations.Items = append(relations.Items, &rel)

list := &ast.List{}
for i, col := range n.AllColumn_name() {
colName := identifier(col.GetText())
target := &ast.ResTarget{
Name: &colName,
Val: c.convert(n.Expr(i)),
}
list.Items = append(list.Items, target)
}

var where ast.Node = nil
if n.WHERE_() != nil {
where = c.convert(n.Expr(len(n.AllExpr()) - 1))
}

stmt := &ast.UpdateStmt{
Relations: relations,
TargetList: list,
WhereClause: where,
FromClause: &ast.List{},
WithClause: nil, // TODO: support with clause
}
if n, ok := n.(interface {
Returning_clause() parser.IReturning_clauseContext
}); ok {
stmt.ReturningList = c.convertReturning_caluseContext(n.Returning_clause())
} else {
stmt.ReturningList = c.convertReturning_caluseContext(nil)
}
if n, ok := n.(interface {
Limit_stmt() parser.ILimit_stmtContext
}); ok {
limitCount, _ := c.convertLimit_stmtContext(n.Limit_stmt())
stmt.LimitCount = limitCount
}
return stmt
}
return stmt

return todo("convertUpdate_stmtContext", n)
}

func (c *cc) convertBetweenExpr(n *parser.Expr_betweenContext) ast.Node {
Expand Down
Loading