-
Notifications
You must be signed in to change notification settings - Fork 0
Added CI pipelines for dev branches and PR #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR refactors static code analysis into a reusable workflow with parameterized coverage reporting, and introduces separate CI pipelines for dev branch pushes and pull request validations while removing the old monolithic workflow. Flow diagram for reusable static code analysis workflowflowchart TD
A["Workflow Triggered"] --> B["Checkout code"]
B --> C["Install uv"]
C --> D["Run Static Code Analysis (pre-commit)"]
D --> E{"coverage_artifact input?"}
E -- true --> F["Run unit tests with coverage report (xml & term)"]
E -- false --> G["Run unit tests with console-only coverage"]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `.github/workflows/ci/static-code-analysis.yml:18` </location>
<code_context>
uses: astral-sh/setup-uv@v5
</code_context>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Add reusable static code analysis workflow and configure CI pipelines for development branches and pull requests to main
CI: