Accept 0 as unitPrice. #4
Open
+10,126
−2,966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…01/product-bundle-active-change-observer
…f github.com:spryker/spryker into bugfix/cc-4001/product-bundle-active-change-observer
* Updated `ProductBundleReaderTest`.
…f github.com:spryker/spryker into bugfix/cc-4001/product-bundle-active-change-observer � Conflicts: � Bundles/ProductBundle/tests/SprykerTest/Zed/ProductBundle/Business/ProductBundleReaderTest.php
* Updated `ProductBundleMapper` class - fixed missed quantity mapping.
* Updated `ProductBundleReaderTest` tests.
* Updated `ProductBundleBeforeUpdateListenerTest` tests.
… and 'master' of github.com:spryker/spryker into bugfix/cc-4001/product-bundle-active-change-observer
* Fixed `CheckoutAddressCollectionForm::mapSubmittedShippingAddressSubFormDataToItemLevelShippingAddresses()` method.
* Fixed `CheckoutAddressCollectionForm` form class. * Added 2 ignored patterns into `phpstan.neon` file.
* Updated `ProductBundleAvailabilityHandler` class.
* Updated `ProductBundleAvailabilityHandler` class.
* Introduced `ProductBundleProductConcreteActivatorAfterUpdatePlugin`. * Updated `ProductBundleBeforeUpdateListener`. * Updated `ProductBundleWriter`.
* Done code refactoring. * Created facade test `SalesFacadeTest::testGetUniqueItemsFromOrder()`. * Updated `SprykerTest\Zed\Sales\Helper\BusinessHelper` to handle bundle items saving.
* TE-10424 Updated architecture-baseline.json as example * TE-10425 Updated arch sniff baselines Co-authored-by: mscherer <mark.scherer@spryker.com>
* TE-10574 Fix up phpstan config
TE-10395 Suppressed PHPStan error hiding code issue
* Fix up PHPStan found mixed smells on object usage.
…age for absent param type (#9109) * TE-10704 Fixed message about not supported return type and added message for absent param type
* TE-10713: Updated PHPStan level part 2. * TE-10713 Updated psalm-reports. * TE-10713 Revert changes in Locale module. * TE-10713 Fixed CS issues.
TE-10112 Checkout Performance issues
* TE-10816 Update psalm baselines, fix issues.
* SUPESC-545 Fix dead deprecation links
* TE-10552 CodeSniffer: Generics for complex objects
* TE-10993 Fix up generics phpdoc-blocks. Co-authored-by: Dmytro Dymarchuk <dmytro.dymarchuk@spryker.com>
* Fix up array docs.
CC-14026 Fixed partial reorder with a product bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
26 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This fixes a bug that avoids a product bundle composed of any product with a price of 0 to be added to the basket.
Checklist