-
Notifications
You must be signed in to change notification settings - Fork 85
Feature/add support for message binding #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timonback
merged 13 commits into
springwolf:master
from
sam0r040:feature/add_support_for_message_binding
Feb 17, 2023
Merged
Feature/add support for message binding #130
timonback
merged 13 commits into
springwolf:master
from
sam0r040:feature/add_support_for_message_binding
Feb 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 16, 2023
timonback
approved these changes
Jan 20, 2023
…nge MessageHelper to not expose the TreeSet that is used for deduplication because a TreeSet breaks equals
…ity without relying on equals based on message name
…ion as part of KafkaAsyncOperationBinding to support documentation of kafka keys as message binding
…s as message binding by using annotations
…n empty message binding so that there is always a message binding
…ct class and method level listener scanners to include an empty message binding so that there is always a message binding
…t class and method level listener scanners to include an empty message binding so that there is always a message binding
…cture of KafkaAsyncMessageBinding to contain a new sub-annotation KafkaAsyncKey to make it more obvious what is part of the key documentation and which is part of the kafka message binding, Add default values for message binding to KafkaConsumer- and KafkaProducerData
…ntain an example for the key and to the change that a kafka message binding is always present
…-amqp-pluging to support message bindings which are sent by springwolf-ui
…DtoDeserializationTest
538be62
to
e6954fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intended as an attempt to fix issue #116 in a generic way. It adds the possibility to document of the message binding.
Docs:
It is currently only implemented for the springwolf-kafka-plugin.
The API for producing messages has been extended to be able to pick up binding information. The controller in of the kafka plugin will use the key from the binding information when producing the message.
This PR works together with springwolf/springwolf-ui#35