MS Entra authentication #448
Conversation
tzolov
added
enhancement
|
@williamspindox thank you for the contribution |
Microsoft Entra authentication, part of the Entra ID identity platform, enhances security and simplifies user sign-in across devices, applications, and services. It goes beyond basic username and password verification, incorporating features like self-service password reset, multifactor authentication, hybrid integration for password changes, passwordless authentication, and policies to enforce strong passwords. These components work together to protect user identities, reduce help desk dependencies, and offer a more streamlined sign-in experience. https://learn.microsoft.com/en-us/entra/identity/authentication/overview-authentication https://learn.microsoft.com/en-us/azure/databricks/dev-tools/service-prin-aad-token
document-readers/tika-reader/pom.xml
Outdated
There was a problem hiding this comment.
It's not related to MS Entra, but it avoid a WARNING during build.
# Conflicts: # spring-ai-spring-boot-autoconfigure/pom.xml
| @@ -46,13 +52,50 @@ public class AzureOpenAiAutoConfiguration { | |||
| @ConditionalOnMissingBean | |||
| public OpenAIClient openAIClient(AzureOpenAiConnectionProperties connectionProperties) { | |||
|
|
|||
| Assert.hasText(connectionProperties.getApiKey(), "API key must not be empty"); | |||
| Assert.hasText(connectionProperties.getEndpoint(), "Endpoint must not be empty"); | |||
| HttpLogOptions options = new HttpLogOptions(); | |||
There was a problem hiding this comment.
It allow to enable logging on request and response to/from Azure. NB. Response body too huge is automatically hide by azuresdk.
|
When can you approve my pull request? Thank you |
# Conflicts: # spring-ai-spring-boot-autoconfigure/pom.xml
# Conflicts: # spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/azure/openai/AzureOpenAiAutoConfiguration.java
|
Apologies, it is a hard area for me to come up to speed and we let this slip. I'm scheduling for the M2 release now. |
# Conflicts: # spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/azure/openai/AzureOpenAiAutoConfiguration.java # spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/azure/openai/AzureOpenAiConnectionProperties.java
# Conflicts: # spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/azure/openai/AzureOpenAiAutoConfiguration.java
|
I'm not sure what was intended for this PR. The resulting changes don't have anything to do with MS Entra authentication and the comment that referred to this code also isn't related to auth, but seems incomplate and not there in the final PR. The resulting change the PR makes is related to where the onxx model is loaded from (http or classpath). I don't know why using http is better over classpath. I'm closing this PR and wont' merge. Please open up a new PR for any of these specific issues with a description explaining the purpose. |
Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:
mainbranch and squash your commits