Skip to content

Improve method param name in ChatClient.Builder.defaultAdvisors() #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve method param name in ChatClient.Builder.defaultAdvisors() #3856

wants to merge 1 commit into from

Conversation

lihuagang03
Copy link

Improve method param name in ChatClient.Builder.defaultAdvisors(Advisor...) from advisor to advisors.
Method parameter naming rules should be consistent.

	interface AdvisorSpec {

		AdvisorSpec advisors(Advisor... advisors);

	}
	interface ChatClientRequestSpec {

		ChatClientRequestSpec advisors(Advisor... advisors);

	}
image

@lihuagang03
Improve method param name in ChatClient.Builder.defaultAdvisors()
3778434 
Signed-off-by: lihuagang03 <bert825_work@163.com>
sunyuhan1998
sunyuhan1998 approved these changes Jul 20, 2025
View reviewed changes
Copy link
Contributor

@sunyuhan1998 sunyuhan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunyuhan1998 sunyuhan1998 sunyuhan1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lihuagang03 @sunyuhan1998