Enable MCP tool callback by default #3043
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the default value of `toolcallback.enabled` property to `true` in both configuration and documentation. - Update `McpClientCommonProperties.Toolcallback` to default `enabled` to `true` and refactor from record to class. - Adjust `@ConditionalOnProperty` in `McpToolCallbackAutoConfiguration` to `matchIfMissing = true` for tool callback. - Update tests to reflect new default behavior: tool callback is now enabled by default when the property is missing. - Update documentation to indicate the new default value for `toolcallback.enabled` is `true`. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
ThomasVitale
approved these changes
May 8, 2025
|
Nice! |
|
merged in c0062dd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toolcallback.enabledproperty totruein both configuration and documentation.McpClientCommonProperties.Toolcallbackto defaultenabledtotrueand refactor from record to class.@ConditionalOnPropertyinMcpToolCallbackAutoConfigurationtomatchIfMissing = truefor tool callback.toolcallback.enabledistrue.