apply builder pattern to OllamaApi #2634
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-jonghoonpark
force-pushed
the
apply-builder-pattern-to-OllamaApi
branch
from
75a5ee2 to
1ae9c99
Compare
models/spring-ai-ollama/src/main/java/org/springframework/ai/ollama/api/OllamaApi.java
Outdated
Show resolved
Hide resolved
|
@dev-jonghoonpark thanks for your contribution! |
dev-jonghoonpark
force-pushed
the
apply-builder-pattern-to-OllamaApi
branch
from
1ae9c99 to
9b9424b
Compare
Signed-off-by: jonghoon park <dev@jonghoonpark.com>
dev-jonghoonpark
force-pushed
the
apply-builder-pattern-to-OllamaApi
branch
from
9b9424b to
3a483f7
Compare
|
conflict resolved. |
|
@dev-jonghoonpark Thanks for adding the builder pattern to OllamaApi. Rebased and merged as d48f4f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apply Builder pattern to
OllamaApito provide a consistent development designrelated: #2164, #2817