Skip to content

GH-2432: Remove unused json-path dependency in spring-ai-openai #2363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

barsha-ghosh721
Copy link
Contributor

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

Signed-off-by: Barsha Ghosh <barshaghosh.721@gmail.com>
@dev-jonghoonpark
Copy link
Contributor

dev-jonghoonpark commented Mar 4, 2025

I think the use of StringUtils in OpenAiAudioSpeechModel should also be removed,
as org.apache.commons.lang3.StringUtils is included in the io.rest-assured:rest-assured-common package.

dependency

Additionally, how about removing the same dependency (io.rest-assured:json-path) from /models/spring-ai-anthropic/pom.xml?


Could you also edit the title and content to include the task for better clarity?

@markpollack
Copy link
Member

should remove the dependency on restassured and commons and replace with spring stringutils

@markpollack markpollack added this to the 1.0.0-RC1 milestone May 8, 2025
@sobychacko sobychacko changed the title GH-2342 GH-2432: Remove unused json-path dependency in spring-ai-openai May 9, 2025
@sobychacko
Copy link
Contributor

Closed via 9de13d1.

@sobychacko sobychacko closed this May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants