Skip to content

Adding Vertex AI Imagen models support #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Adding Vertex AI Imagen models support #2144

wants to merge 9 commits into from

Conversation

Marzouki-Sami
Copy link

Closes gh-2133

Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

@Marzouki-Sami Marzouki-Sami marked this pull request as draft January 29, 2025 07:07
@Marzouki-Sami Marzouki-Sami marked this pull request as ready for review January 29, 2025 07:12
@markpollack
Copy link
Member

@ddobrin can you please take a look?

@turchinc
Copy link
Contributor

Any update here? I am also interested in this feature.

@byungjunn
Copy link

I am currently using this feature as a custom-made version. I hope it gets updated soon. If help is needed, I would be willing to participate.

@ilayaperumalg
Copy link
Member

@byungjunn Thanks! Any help reviewing the PR is much appreciated.

@byungjunn
Copy link

@Marzouki-Sami
https://spring.io/blog/2025/03/25/spring-ai-update-to-snapshots
After the update, there have been many changes, so I think you need to rebase onto the main branch.

@Marzouki-Sami Marzouki-Sami changed the base branch from 1.0.0-M5 to main June 5, 2025 11:43
Marzouki-Sami and others added 5 commits June 16, 2025 11:09
@Marzouki-Sami
Adding Vertex AI Imagen models support
489767d 
Closes spring-projectsgh-2133

Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
@Marzouki-Sami @byungjunn
Update spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-ima…
0fe3fff 
…gen/pom.xml


Updating the version.

Co-authored-by: ByungJun <kbj7227@naver.com>
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
@Marzouki-Sami @byungjunn
Update spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-ima…
67c46d1 
…gen/pom.xml


changing artifactId

Co-authored-by: ByungJun <kbj7227@naver.com>
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
@Marzouki-Sami @byungjunn
Update spring-ai-spring-boot-starters/spring-ai-starter-vertex-ai-ima…
adafe0b 
…gen/pom.xml


removing unnecessary spaces

Co-authored-by: ByungJun <kbj7227@naver.com>
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
@Marzouki-Sami @byungjunn
updating artifactId
73c3245 
Co-authored-by: ByungJun <kbj7227@naver.com>
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
@Marzouki-Sami
Copy link
Author

@byungjunn @ilayaperumalg @markpollack i had some issues with resolving the conflict and to resolve the conflict i had to remove the commits, doing that closed this PR is it possible to reopen it, if not i will create a new PR and link it to this one.

@ilayaperumalg ilayaperumalg reopened this Jun 17, 2025
@Marzouki-Sami Marzouki-Sami force-pushed the gh-2133 branch 2 times, most recently from 7fef979 to 54f3ba7 Compare June 17, 2025 09:47
sami.marzouki and others added 2 commits June 17, 2025 10:49
@Marzouki-Sami
resolving conflict
a242b4f 
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
@Marzouki-Sami
updating to version 1.1.0-SNAPSHOT
9b223f9 
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
@Marzouki-Sami
Copy link
Author

@byungjunn thanks for the review the mentioned points above are fixed. Can you check them?

@Marzouki-Sami
Merge branch 'main' into spring-projectsgh-2133
8289c53 
Signed-off-by: Sami Marzouki <73302274+Marzouki-Sami@users.noreply.github.com>
@Marzouki-Sami
Copy link
Author

Any updates?

@Marzouki-Sami
Update VertexAiImagenImageGenerationMetadata.java
f341567 
switching constructor params to match only call in VertexAiImagenImageModel.java

Signed-off-by: Marzouki-Sami samymarzouki502@gmail.com
Signed-off-by: Marzouki-Sami <samymarzouki502@gmail.com>
@Marzouki-Sami
Copy link
Author

Just a minor change added in the last commit (f341567). Switching the constructor params ( mimetype and model) of VertexAiImagenImageGenerationMetadata to be in the same order of usage in VertexAiImagenImageModel ( line 177)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byungjunn byungjunn byungjunn approved these changes

Assignees
No one assigned
Labels
image models vertex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: adding Vertex Ai Imagen models support
5 participants
@Marzouki-Sami @markpollack @turchinc @byungjunn @ilayaperumalg