feat: added missed builder methods for VectorStoreChatMemoryAdvisor; #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t one with all fields feat: added missed builder methods; deprecated all constructors except one with all fields
| @@ -209,10 +219,25 @@ public Builder withSystemTextAdvise(String systemTextAdvise) { | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder withConversationId(String conversationId) { | |||
There was a problem hiding this comment.
@ogbozoyan Thanks for your PR. These methods are already part of the AbstractChatMemoryAdvisor.AbstractBuilder and hence they don't need to be added here. I will remove these but merge your PR with the deprecated constructors.
|
Rebased, removed the builder methods which were part of the AbstractChatMemoryAdvisor's Builder and merged as cd871ea. @ogbozoyan Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1823
mainbranch and squash your commits