Contribute Oracle Coherence vector store implementation #1627
Conversation
|
@markpollack Just a friendly nudge to review this PR... ;-) |
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| public class CoherenceVectorStoreIT { |
There was a problem hiding this comment.
Hi, I see Oracle Coherence CE has some docker images available here.
I wonder if we can switch and use it along with Testcontainers. Later, when autoconfiguration is added then adding Service Connections support for Testcontainers and Docker Compose would be great.
There was a problem hiding this comment.
We do have Docker images, but no OOB support for Testcontainers that I'm aware of, so someone would need to write that.
The thing is, we had a way to start a multi-process cluster long before Testcontainers existed, in the form of Oracle Bedrock, so that's what we used to test this integration as well.
I'm not saying it's better than Testcontainers, but it's lighter-weight and faster to run, as it doesn't require or has to download Docker image on every build -- it simply starts several Coherence cluster members, and runs the tests.
Anyway, I'd like to get this in as-is, so we have the integration people can use, but am open to refactoring tests to use Testcontainers long-term, if there are benefits to doing that.
|
@aseovic having some build issues with removing boot deps and installing checkstyle... will merge once done. A couple things wrt to testing. Having the automated tests is important as there will always be drift. I'm not married to test containers, but getting something in place would be useful. Also, we do have https://github.com/spring-projects/spring-ai-integration-tests where most tests are failing due to lack of API keys, but are in the process of sorting that out. There is also a contribution for OCI Embedding model, but I can't get oracle cloud to cooperate with me. See this comment. Is there something you can do to help me out there? |
Of course, and we do have tests in the PR. They are just not using TC, but our own distributed testing framework instead.
I'm not sure. I only have access to resources in Phoenix and Ashburn regions, and that's through my team/org, so not publicly shareable. I'm a bit confused though -- it says you merged it on Sep 26? |
|
@markpollack Any chance we can get this merged soon? Keeping it in sync with the changes in main is pita... |
|
on it |
|
Sure, will do. Thanks!
|
We added support for vector storage and search in Oracle Coherence CE 24.09, and would like to contribute Spring AI vector store implementation (and Spring Boot Starter) for it.