feat: OCP maps/pen 42 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…raform-aws-vpc into ocp-maps/pen-42
as-extern-mbertram
requested review from
spr-mweber3
and removed request for
gentgme
plcoelho
reviewed
Aug 22, 2024
main.tf
Outdated
| @@ -115,7 +116,10 @@ resource "aws_subnet" "public" { | |||
| { | |||
| Name = try( | |||
| var.public_subnet_names[count.index], | |||
| format("${var.name}-${var.public_subnet_suffix}-%s", element(var.azs, count.index)) | |||
| format("${var.name_prefix}%s-%s-sub-${var.public_subnet_suffix}", | |||
There was a problem hiding this comment.
Over here we have no dash (-) between the name_prefix and the next string, but we do have a dash before the suffix.
Is this the expected approach?
There was a problem hiding this comment.
Changes:
- Add the after
${var.name_prefix} - Add
${var.region_shortcode}after name_prefix
plcoelho
requested changes
Aug 22, 2024
main.tf
Outdated
| @@ -115,7 +116,10 @@ resource "aws_subnet" "public" { | |||
| { | |||
| Name = try( | |||
| var.public_subnet_names[count.index], | |||
| format("${var.name}-${var.public_subnet_suffix}-%s", element(var.azs, count.index)) | |||
| format("${var.name_prefix}%s-%s-sub-${var.public_subnet_suffix}", | |||
There was a problem hiding this comment.
Changes:
- Add the after
${var.name_prefix} - Add
${var.region_shortcode}after name_prefix
tgw.tf
Outdated
| ) | ||
| } | ||
|
|
||
| # There are as many routing tables as the number of NAT gateways |
as-extern-mbertram
requested review from
gentgme and
plcoelho
and removed request for
spr-mweber3
gentgme
reviewed
Aug 27, 2024
gentgme
reviewed
Aug 27, 2024
gentgme
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add TGW subnets and creation of an attachment to the VPC module. Also naming is changed for the resources to reflect the naming recommendations.