Skip to content

feat PA-5238: extend renderAuthComponent interface to allow inline rendering #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

eschmittel
Copy link
Contributor

What

  • extend renderAuthComponent interface with boolean for inline rendering

Why

The wonderwall should be flexible and should be renderable as either overlay or inline in any container of your choosing.

@eschmittel eschmittel requested a review from fgerardwltn24 April 7, 2025 12:14
@can-axelspringer
Copy link

This pull request includes several updates to the GitHub Actions workflows and the ps-web-apis.ts file. The main changes involve updating the versions of GitHub Actions used and adding a new configuration option for rendering.

GitHub Actions Workflow Updates:

Codebase Enhancements:

  • src/ps-web-apis.ts: Added a new inlineRender boolean parameter to the AuthComponentConfig interface to allow rendering Wonderwall directly in the container instead of as an overlay. [1] [2]

@eschmittel eschmittel merged commit 08dec15 into master Apr 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants