Skip to content

feat PA-5050: generalize auth component interface #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

feat PA-5050: generalize auth component interface #78

merged 1 commit into from
Jan 23, 2025

Conversation

eschmittel
Copy link
Contributor

What

  • Adjust renderAuthComponent interface
  • use one general config object for all settings
  • make container element options

Why

  • the container element should be optional because we will render the component in an overlay by default.
  • One general config object is also easier to adjust and extend in the future than order parameters. The interface is less likely to be not backwards compatible that way

@eschmittel eschmittel merged commit 7ccabcd into master Jan 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgerardwltn24 fgerardwltn24 Awaiting requested review from fgerardwltn24

@bwagneras bwagneras Awaiting requested review from bwagneras

@can-axelspringer can-axelspringer Awaiting requested review from can-axelspringer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@eschmittel