Skip to content

Commit 2740d81

Browse files
committed
Add Eclipse Checkstyle Plugin support
Update the Eclipse plugin to optionally support Eclipse Checkstyle. Closes gh-82
1 parent 68cf0b4 commit 2740d81

File tree

5 files changed

+29
-2
lines changed

5 files changed

+29
-2
lines changed

pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
3333
<java.version>1.8</java.version>
3434
<eclipse.repository>https://download.eclipse.org/releases/2019-03/201903201000</eclipse.repository>
35+
<eclipse.checkstyle.repository>https://dl.bintray.com/eclipse-cs/eclipse-cs/8.18.0</eclipse.checkstyle.repository>
3536
<tycho.disableP2Mirrors>true</tycho.disableP2Mirrors>
3637
<ant.version>1.8.1</ant.version>
3738
<ant-contrib.version>1.0b3</ant-contrib.version>
@@ -590,6 +591,11 @@
590591
<layout>p2</layout>
591592
<url>${eclipse.repository}</url>
592593
</repository>
594+
<repository>
595+
<id>eclipse-checkstyle</id>
596+
<layout>p2</layout>
597+
<url>${eclipse.checkstyle.repository}</url>
598+
</repository>
593599
</repositories>
594600
<modules>
595601
<module>spring-javaformat</module>

spring-javaformat-eclipse/io.spring.javaformat.eclipse/META-INF/MANIFEST.MF

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,10 @@ Require-Bundle: org.eclipse.ui,
1515
org.eclipse.m2e.core;resolution:=optional,
1616
org.eclipse.m2e.maven.runtime;resolution:=optional,
1717
org.eclipse.buildship.core;resolution:=optional,
18+
net.sf.eclipsecs.core;bundle-version="8.18.0";resolution:=optional,
1819
org.slf4j.api;bundle-version="1.7.0"
1920
Bundle-ClassPath: .,
2021
lib/spring-javaformat-formatter-eclipse.jar,
21-
lib/spring-javaformat-formatter.jar
22+
lib/spring-javaformat-formatter.jar,
23+
lib/spring-javaformat-checkstyle.jar
2224
Bundle-ActivationPolicy: lazy

spring-javaformat-eclipse/io.spring.javaformat.eclipse/build.properties

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@ bin.includes = META-INF/,\
44
plugin.xml,\
55
lifecycle-mapping-metadata.xml,\
66
lib/spring-javaformat-formatter-eclipse.jar,\
7-
lib/spring-javaformat-formatter.jar
7+
lib/spring-javaformat-formatter.jar,
8+
lib/spring-javaformat-checkstyle.jar
89

spring-javaformat-eclipse/io.spring.javaformat.eclipse/plugin.xml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,16 @@
2525
class="io.spring.javaformat.eclipse.Startup">
2626
</startup>
2727
</extension>
28+
<extension
29+
point="net.sf.eclipsecs.core.checkstyleAddonProvider">
30+
</extension>
31+
<extension
32+
id="id2"
33+
point="net.sf.eclipsecs.core.configurations">
34+
<check-configuration
35+
description="Spring Build-in configuration"
36+
location="io/spring/javaformat/checkstyle/checkstyle.xml"
37+
name="Spring Builtin Checks">
38+
</check-configuration>
39+
</extension>
2840
</plugin>

spring-javaformat-eclipse/io.spring.javaformat.eclipse/pom.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,11 @@
2222
<scope>runtime</scope>
2323
<version>${project.version}</version>
2424
</dependency>
25+
<dependency>
26+
<groupId>io.spring.javaformat</groupId>
27+
<artifactId>spring-javaformat-checkstyle</artifactId>
28+
<scope>runtime</scope>
29+
<version>${project.version}</version>
30+
</dependency>
2531
</dependencies>
2632
</project>

0 commit comments

Comments
 (0)