Skip to content

Commit 68cf0b4

Browse files
committed
Merge pull request #62 from vpavic
* pr/62: Add tests and for SpringImportOrderCheck Add SpringImportOrderCheck with package support Reorder imports based on `io.spring` package
2 parents 0456ebe + 21580c9 commit 68cf0b4

File tree

34 files changed

+222
-45
lines changed

34 files changed

+222
-45
lines changed

.eclipse/org.eclipse.jdt.ui.prefs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ formatter_settings_version=13
6464
org.eclipse.jdt.ui.exception.name=e
6565
org.eclipse.jdt.ui.gettersetter.use.is=true
6666
org.eclipse.jdt.ui.ignorelowercasenames=true
67-
org.eclipse.jdt.ui.importorder=java;javax;;org.springframework;\#;
67+
org.eclipse.jdt.ui.importorder=java;javax;;io.spring;\#;
6868
org.eclipse.jdt.ui.javadoc=true
6969
org.eclipse.jdt.ui.keywordthis=false
7070
org.eclipse.jdt.ui.ondemandthreshold=9999

spring-javaformat-eclipse/io.spring.javaformat.eclipse/src/io/spring/javaformat/eclipse/Activator.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,11 @@
1616

1717
package io.spring.javaformat.eclipse;
1818

19-
import io.spring.javaformat.eclipse.gradle.RefreshProjectSettingsListeners;
2019
import org.eclipse.ui.plugin.AbstractUIPlugin;
2120
import org.osgi.framework.BundleContext;
2221

22+
import io.spring.javaformat.eclipse.gradle.RefreshProjectSettingsListeners;
23+
2324
/**
2425
* The activator class controls the plug-in life cycle.
2526
*

spring-javaformat-eclipse/io.spring.javaformat.eclipse/src/io/spring/javaformat/eclipse/formatter/SpringCodeFormatter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@
1818

1919
import java.util.Map;
2020

21-
import io.spring.javaformat.formatter.Formatter;
2221
import org.eclipse.jdt.core.formatter.CodeFormatter;
2322
import org.eclipse.jface.text.IRegion;
2423
import org.eclipse.text.edits.TextEdit;
2524

25+
import io.spring.javaformat.formatter.Formatter;
26+
2627
/**
2728
* Eclipse {@link CodeFormatter} for Spring formatting.
2829
*

spring-javaformat-eclipse/io.spring.javaformat.eclipse/src/io/spring/javaformat/eclipse/gradle/RefreshProjectsSettingsJob.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@
2222
import java.util.Optional;
2323
import java.util.Set;
2424

25-
import io.spring.javaformat.eclipse.Executor;
26-
import io.spring.javaformat.eclipse.Messages;
27-
import io.spring.javaformat.eclipse.projectsettings.ProjectSettingsFilesLocator;
2825
import org.eclipse.buildship.core.GradleBuild;
2926
import org.eclipse.buildship.core.internal.CorePlugin;
3027
import org.eclipse.buildship.core.internal.workspace.FetchStrategy;
@@ -43,6 +40,10 @@
4340
import org.gradle.tooling.model.GradleTask;
4441
import org.gradle.tooling.model.eclipse.EclipseProject;
4542

43+
import io.spring.javaformat.eclipse.Executor;
44+
import io.spring.javaformat.eclipse.Messages;
45+
import io.spring.javaformat.eclipse.projectsettings.ProjectSettingsFilesLocator;
46+
4647
/**
4748
* Job to trigger refresh of project specific settings when the gradle plugin is used.
4849
*

spring-javaformat-eclipse/io.spring.javaformat.eclipse/src/io/spring/javaformat/eclipse/m2e/ProjectSettingsConfigurator.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,17 @@
2020
import java.util.ArrayList;
2121
import java.util.List;
2222

23-
import io.spring.javaformat.eclipse.Executor;
24-
import io.spring.javaformat.eclipse.Messages;
25-
import io.spring.javaformat.eclipse.projectsettings.ProjectSettingsFiles;
26-
import io.spring.javaformat.eclipse.projectsettings.ProjectSettingsFilesLocator;
2723
import org.apache.maven.project.MavenProject;
2824
import org.eclipse.core.runtime.CoreException;
2925
import org.eclipse.core.runtime.IProgressMonitor;
3026
import org.eclipse.m2e.core.project.configurator.AbstractProjectConfigurator;
3127
import org.eclipse.m2e.core.project.configurator.ProjectConfigurationRequest;
3228

29+
import io.spring.javaformat.eclipse.Executor;
30+
import io.spring.javaformat.eclipse.Messages;
31+
import io.spring.javaformat.eclipse.projectsettings.ProjectSettingsFiles;
32+
import io.spring.javaformat.eclipse.projectsettings.ProjectSettingsFilesLocator;
33+
3334
/**
3435
* Configurator to apply project specific settings.
3536
*

spring-javaformat-gradle/spring-javaformat-gradle-plugin/src/main/java/io/spring/javaformat/gradle/CheckTask.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,11 @@
2121
import java.util.List;
2222
import java.util.stream.Collectors;
2323

24-
import io.spring.javaformat.formatter.FileEdit;
2524
import org.gradle.api.GradleException;
2625
import org.gradle.api.tasks.TaskAction;
2726

27+
import io.spring.javaformat.formatter.FileEdit;
28+
2829
/**
2930
* {@link FormatterTask} to check formatting.
3031
*

spring-javaformat-gradle/spring-javaformat-gradle-plugin/src/main/java/io/spring/javaformat/gradle/FormatTask.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,12 @@
1818

1919
import java.io.IOException;
2020

21-
import io.spring.javaformat.formatter.FileEdit;
22-
import io.spring.javaformat.formatter.FileFormatterException;
2321
import org.gradle.api.GradleException;
2422
import org.gradle.api.tasks.TaskAction;
2523

24+
import io.spring.javaformat.formatter.FileEdit;
25+
import io.spring.javaformat.formatter.FileFormatterException;
26+
2627
/**
2728
* {@link FormatterTask} to apply formatting.
2829
*

spring-javaformat-gradle/spring-javaformat-gradle-plugin/src/main/java/io/spring/javaformat/gradle/FormatterTask.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,13 @@
1919
import java.nio.charset.Charset;
2020
import java.util.stream.Stream;
2121

22-
import io.spring.javaformat.formatter.FileEdit;
23-
import io.spring.javaformat.formatter.FileFormatter;
2422
import org.gradle.api.tasks.Input;
2523
import org.gradle.api.tasks.Optional;
2624
import org.gradle.api.tasks.SourceTask;
2725

26+
import io.spring.javaformat.formatter.FileEdit;
27+
import io.spring.javaformat.formatter.FileFormatter;
28+
2829
/**
2930
* Abstract base class for formatter tasks.
3031
*

spring-javaformat-gradle/spring-javaformat-gradle-plugin/src/test/java/io/spring/javaformat/gradle/CheckTaskTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,13 @@
1818

1919
import java.io.IOException;
2020

21-
import io.spring.javaformat.gradle.testkit.GradleBuild;
2221
import org.gradle.testkit.runner.BuildResult;
2322
import org.gradle.testkit.runner.TaskOutcome;
2423
import org.junit.Rule;
2524
import org.junit.Test;
2625

26+
import io.spring.javaformat.gradle.testkit.GradleBuild;
27+
2728
import static org.assertj.core.api.Assertions.assertThat;
2829

2930
/**

spring-javaformat-gradle/spring-javaformat-gradle-plugin/src/test/java/io/spring/javaformat/gradle/FormatTaskTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,13 @@
2020
import java.io.IOException;
2121
import java.nio.file.Files;
2222

23-
import io.spring.javaformat.gradle.testkit.GradleBuild;
2423
import org.gradle.testkit.runner.BuildResult;
2524
import org.gradle.testkit.runner.TaskOutcome;
2625
import org.junit.Rule;
2726
import org.junit.Test;
2827

28+
import io.spring.javaformat.gradle.testkit.GradleBuild;
29+
2930
import static org.assertj.core.api.Assertions.assertThat;
3031

3132
/**

0 commit comments

Comments
 (0)