Enable proper override of binder beans with user-defined configurations in a multi-binder scenario #3123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…user-defined beans over binder's conditional beans in a multi-binder scenario This change modifies the loading order in DefaultBinderFactory.initializeBinderContextSimple to ensure that user configuration classes specified via spring.main.sources are loaded before binder configuration classes. This allows @ConditionalOnMissingBean annotations in the binder configurations to properly detect user-provided beans. Previously, when using KafkaBinderConfiguration with @ConditionalOnMissingBean(KafkaBinderMetrics.class), even if the user had configured a custom KafkaBinderMetrics bean via spring.main.sources, the condition would not work correctly because binder classes were loaded first. Fixes spring-cloudgh-3114 Signed-off-by: ferblaca <fernandobc@ext.inditex.com>
|
@ferblaca I thought you would add a |
|
Hi @sobychacko!! After reviewing the issue, I noticed that it seemed to be a more general BUG in And to avoid mixing things up, I preferred to create this PR to solve this more general problem first, so the |
ferblaca
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3114