Code cleanup #2990
Closed
Code cleanup #2990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegz
reviewed
Aug 19, 2024
| @@ -193,7 +193,7 @@ void parentConnectionFactoryInheritedByDefault() throws Exception { | |||
| private void checkCustomizedArgs() throws MalformedURLException, URISyntaxException, InterruptedException { | |||
| List<Map<String, Object>> bindings = RestUtils.getBindingsBySource(client, uri, "/", "process-in-0"); | |||
| int n = 0; | |||
| while (n++ < 100 && bindings == null || bindings.size() < 1) { | |||
There was a problem hiding this comment.
I have not looked at this code, but usually < 1 implies that there may be two or more bindings, for which there would be additional handling. Please take a look. While < 1 is effectively the same as empty, i just want to make sure we're not missing something
There was a problem hiding this comment.
Thank you very much @olegz . I hadn't looked at the situation from this perspective. I'm reverting my change right away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.