RoutePredicateHandlerMapping doesn't hanle Mono errors properly #3808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
* Add autoconfiguration tests. Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
This is temporary for backwards compatibility. Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: raccoonback <kosb15@naver.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Changes java distribution to liberica Signed-off-by: Spencer Gibb <sgibb@pivotal.io> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
See gh-3647 Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: Stepan Mikhailiuk <istepancar@gmail.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: Stepan Mikhailiuk <istepancar@gmail.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: Stepan Mikhailiuk <istepancar@gmail.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: Stepan Mikhailiuk <istepancar@gmail.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: jiangyuan <joe469391363@gmail.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: jiangyuan <joe469391363@gmail.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: jiangyuan <joe469391363@gmail.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
…uery parameter Signed-off-by: raccoonback <kosb15@naver.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
Signed-off-by: Olga Maciaszek-Sharma <olga.maciaszek-sharma@broadcom.com> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
* Add documentation for routing to functions This one specifically refers to using Spring Cloud Function framework Signed-off-by: Oleg Zhurakousky <ozhurakousky@vmware.com> * Update java-routes-api.adoc Signed-off-by: Spencer Gibb <sgibb@pivotal.io> --------- Signed-off-by: Oleg Zhurakousky <ozhurakousky@vmware.com> Signed-off-by: Spencer Gibb <sgibb@pivotal.io> Co-authored-by: Spencer Gibb <sgibb@pivotal.io> Signed-off-by: tassoc <claudio.tasso@tasgroup.eu>
|
Unfortunately, you've got a number of commits here that aren't part of your PR |
|
Yes, I had some problems with git merging, because my commit message was not signed. I will close this PR and create a new one now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR #2884 introduces a regression in error handling.
In fact, if an async predicate raises a Mono error, it is not properly caught. The error bubbles up and the client receives an internal server error.
The improper error handling was already spotted in this comment:
#2977 (comment)