spree 4.7 #161

rahul2103 · 2024-01-29T12:54:56Z

No description provided.

houndci-bot · 2024-01-29T12:55:01Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

+              with_manage_ability_check(::Spree::BookkeepingDocument).
+              with_label_translation_key('admin.documents').
+              with_items(items).
+              build


Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines.

houndci-bot · 2024-01-29T12:55:01Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

+          ::Spree::Admin::MainMenu::SectionBuilder.new('documents', 'file.svg').
+              with_manage_ability_check(::Spree::BookkeepingDocument).
+              with_label_translation_key('admin.documents').
+              with_items(items).


Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
Layout/DotPosition: Place the . on the next line, together with the method name.

houndci-bot · 2024-01-29T12:55:02Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

+
+          ::Spree::Admin::MainMenu::SectionBuilder.new('documents', 'file.svg').
+              with_manage_ability_check(::Spree::BookkeepingDocument).
+              with_label_translation_key('admin.documents').


Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
Layout/DotPosition: Place the . on the next line, together with the method name.

houndci-bot · 2024-01-29T12:55:02Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

+          ]
+
+          ::Spree::Admin::MainMenu::SectionBuilder.new('documents', 'file.svg').
+              with_manage_ability_check(::Spree::BookkeepingDocument).


Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines.
Layout/DotPosition: Place the . on the next line, together with the method name.

houndci-bot · 2024-01-29T12:55:02Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

+              build
+          ]
+
+          ::Spree::Admin::MainMenu::SectionBuilder.new('documents', 'file.svg').


Layout/DotPosition: Place the . on the next line, together with the method name.

houndci-bot · 2024-01-29T12:55:02Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

+        def build
+          items = [
+            ::Spree::Admin::MainMenu::ItemBuilder.new('invoices', ::Spree::Core::Engine.routes.url_helpers.admin_bookkeeping_documents_path(q: { template_eq: 'invoice' })).
+              with_label_translation_key('admin.invoices').


Layout/DotPosition: Place the . on the next line, together with the method name.

houndci-bot · 2024-01-29T12:55:02Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

+
+        def build
+          items = [
+            ::Spree::Admin::MainMenu::ItemBuilder.new('invoices', ::Spree::Core::Engine.routes.url_helpers.admin_bookkeeping_documents_path(q: { template_eq: 'invoice' })).


Metrics/LineLength: Line is too long. [172/80]
Layout/DotPosition: Place the . on the next line, together with the method name.

houndci-bot · 2024-01-29T12:55:02Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

+      class PrintInvoiceBuilder
+        include ::Spree::Core::Engine.routes.url_helpers
+
+        def build


Metrics/AbcSize: Assignment Branch Condition size for build is too high. [21.02/15]
Metrics/MethodLength: Method has too many lines. [17/10]

houndci-bot · 2024-01-29T12:55:02Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

+module SpreePrintInvoice
+  module Admin
+    module MainMenu
+      class PrintInvoiceBuilder


Style/Documentation: Missing top-level class documentation comment.

houndci-bot · 2024-01-29T12:55:02Z

app/models/spree_print_invoice/admin/main_menu/print_invoice_builder.rb

@@ -0,0 +1,30 @@
+module SpreePrintInvoice


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2024-02-23T12:21:50Z

app/models/spree_print_invoice/spree/order_decorator.rb

+      end
+
+      def pdf_storage_path(template)
+        ActiveSupport::Deprecation.warn('This API has changed: Please use order.{packaging_slip, invoice}.pdf_file_path instead')


Metrics/LineLength: Line is too long. [129/80]

houndci-bot · 2024-02-23T12:21:50Z

app/models/spree_print_invoice/spree/order_decorator.rb

+      end
+
+      def pdf_file_path
+        ActiveSupport::Deprecation.warn('This API has changed: Please use order.invoice.pdf_file_path instead')


Metrics/LineLength: Line is too long. [111/80]

houndci-bot · 2024-02-23T12:21:50Z

app/models/spree_print_invoice/spree/order_decorator.rb

+      end
+
+      def pdf_filename
+        ActiveSupport::Deprecation.warn('This API has changed: Please use order.invoice.file_name instead')


Metrics/LineLength: Line is too long. [107/80]

houndci-bot · 2024-02-23T12:21:50Z

app/models/spree_print_invoice/spree/order_decorator.rb

+      # ones on Spree::BookkeepingDocument
+      #
+      def pdf_file
+        ActiveSupport::Deprecation.warn('This API has changed: Please use order.invoice.pdf instead')


Metrics/LineLength: Line is too long. [101/80]

houndci-bot · 2024-02-23T12:21:50Z

app/models/spree_print_invoice/spree/order_decorator.rb

+        base.state_machine.before_transition to: :complete, do: :invoice_for_order
+      end
+
+      # Backwards compatibility stuff. Please don't use these methods, rather use the


Metrics/LineLength: Line is too long. [85/80]

houndci-bot · 2024-02-23T12:21:51Z

config/initializers/print_invoice.rb

+    )
+
+     Rails.application.config.spree_backend.main_menu.add_to_section('settings',
+      ::Spree::Admin::MainMenu::ItemBuilder.new('print_invoice.settings', ::Spree::Core::Engine.routes.url_helpers.edit_admin_print_invoice_settings_path).


Layout/AlignParameters: Align the parameters of a method call if they span more than one line.
Metrics/LineLength: Line is too long. [155/80]
Layout/DotPosition: Place the . on the next line, together with the method name.

houndci-bot · 2024-02-23T12:21:51Z

config/initializers/print_invoice.rb

+        build
+    )
+
+     Rails.application.config.spree_backend.main_menu.add_to_section('settings',


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2024-02-23T12:21:51Z

config/initializers/print_invoice.rb

+    Rails.application.config.spree_backend.tabs[:order].add(
+      ::Spree::Admin::Tabs::TabBuilder.new(::Spree.t(:documents, scope: [:print_invoice]), ->(resource) { ::Spree::Core::Engine.routes.url_helpers.admin_order_bookkeeping_documents_path(resource) }).
+        with_icon_key('file.svg').
+        with_active_check.


Layout/DotPosition: Place the . on the next line, together with the method name.

houndci-bot · 2024-02-23T12:21:51Z

config/initializers/print_invoice.rb

+
+    Rails.application.config.spree_backend.tabs[:order].add(
+      ::Spree::Admin::Tabs::TabBuilder.new(::Spree.t(:documents, scope: [:print_invoice]), ->(resource) { ::Spree::Core::Engine.routes.url_helpers.admin_order_bookkeeping_documents_path(resource) }).
+        with_icon_key('file.svg').


Layout/DotPosition: Place the . on the next line, together with the method name.

houndci-bot · 2024-02-23T12:21:51Z

config/initializers/print_invoice.rb

+    Rails.application.config.spree_backend.main_menu.insert_after('dashboard', ::SpreePrintInvoice::Admin::MainMenu::PrintInvoiceBuilder.new.build)
+
+    Rails.application.config.spree_backend.tabs[:order].add(
+      ::Spree::Admin::Tabs::TabBuilder.new(::Spree.t(:documents, scope: [:print_invoice]), ->(resource) { ::Spree::Core::Engine.routes.url_helpers.admin_order_bookkeeping_documents_path(resource) }).


Metrics/LineLength: Line is too long. [199/80]
Layout/DotPosition: Place the . on the next line, together with the method name.

spree 4.7

1cbe1e8

houndci-bot reviewed Jan 29, 2024

View reviewed changes

rails 7 dependency

067dc2b

houndci-bot reviewed Feb 23, 2024

View reviewed changes

spree 4.7 #161

Are you sure you want to change the base?

spree 4.7 #161

Uh oh!

Conversation

rahul2103 commented Jan 29, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants