-
Notifications
You must be signed in to change notification settings - Fork 2
Support ServiceBusProcessor #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ServiceBusProcessor #59
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. I have added a few comments.
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusClient.cs
Outdated
Show resolved
Hide resolved
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
@altsak I have added responses to your comments + I have synchronized the PR with I also checked the test code (impressive work btw) so after the comments are resolved and CI fixed, we are ready to merge. |
@tomas-pajurek Thanks for the feedback and for looking the tests as well! I did the |
src/Spotflow.InMemory.Azure.ServiceBus/InMemoryServiceBusProcessor.cs
Outdated
Show resolved
Hide resolved
Head branch was pushed to by a user without write access
@altsak Thanks for the contribution. PR was merged and will create a release shortly. |
No description provided.