Skip to content

Conversation

altsak
Copy link
Contributor

@altsak altsak commented Aug 15, 2025

No description provided.

@tomas-pajurek tomas-pajurek linked an issue Aug 15, 2025 that may be closed by this pull request
Copy link
Member

@tomas-pajurek tomas-pajurek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I have added a few comments.

@tomas-pajurek
Copy link
Member

tomas-pajurek commented Aug 21, 2025

@altsak I have added responses to your comments + I have synchronized the PR with main branch and allowed CI run, including publishing preview artifacts. The dotnet format in CI is failing so please format the code via just running dotnet format in the on the entire solution.

I also checked the test code (impressive work btw) so after the comments are resolved and CI fixed, we are ready to merge.

@altsak
Copy link
Contributor Author

altsak commented Aug 22, 2025

@tomas-pajurek Thanks for the feedback and for looking the tests as well! I did the dotnet format on the solution as you suggested and I think the CI passes now (it seems that Rider wasn't respecting .editorconfig). Let me know if anything else is needed.

@tomas-pajurek tomas-pajurek enabled auto-merge (squash) August 22, 2025 12:22
auto-merge was automatically disabled August 22, 2025 13:20

Head branch was pushed to by a user without write access

@tomas-pajurek tomas-pajurek enabled auto-merge (squash) August 22, 2025 15:59
@tomas-pajurek tomas-pajurek merged commit 9316f17 into spotflow-io:main Aug 23, 2025
29 of 30 checks passed
@tomas-pajurek
Copy link
Member

@altsak Thanks for the contribution. PR was merged and will create a release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Add support for ServiceBusProcessor

2 participants