-
-
Notifications
You must be signed in to change notification settings - Fork 34
📝 🐛 Update contributing.md #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1. Changed the order to ensure dependencies are installed locally 2. Added more clarity for different OS on activating venv 3. app.py doesnt exist, changed to main.py 🐛
Reviewer's GuideRefactors the contributing guide by moving virtual environment creation ahead of dependency installation (with corresponding step renumbering), adds clear OS-specific venv activation instructions, and corrects the development server launch command from File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Corrected windows script Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @CRIMSONHydra - I've reviewed your changes - here's some feedback:
- Fix the typo in step 10: change “Format you code” to “Format your code.”
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Typo Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
In the how to contribute section:
Summary by Sourcery
Update the contributing guide to clarify environment setup, renumber steps, and fix the development server run command.
Documentation: