Fix the @Retry documentation #2174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vampire
force-pushed
the
vampire/fix-retry-docs
branch
from
0fbb1a3 to
ad388ae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2174 +/- ##
=========================================
Coverage 81.90% 81.90%
Complexity 4732 4732
=========================================
Files 463 463
Lines 14767 14767
Branches 1869 1869
=========================================
Hits 12095 12095
Misses 1981 1981
Partials 691 691
🚀 New features to boost your workflow:
|
Vampire
force-pushed
the
vampire/fix-retry-docs
branch
from
ad388ae to
592f7a9
Compare
Vampire
force-pushed
the
vampire/fix-retry-docs
branch
from
592f7a9 to
a8dd99c
Compare
Vampire
commented
Jun 6, 2025
| @@ -351,63 +351,27 @@ With the flag `applyGlobalTimeoutToFixtures` you can control if the global timeo | |||
| The `@Retry` extensions can be used for flaky integration tests, where remote systems can fail sometimes. | |||
| By default it retries an iteration `3` times with `0` delay if either an `Exception` or `AssertionError` has been thrown, all this is configurable. | |||
| In addition, an optional `condition` closure can be used to determine if a feature should be retried. | |||
| It also provides special support for data driven features, offering to either retry all iterations or just the failing ones. | |||
| In its standard mode it only retries the feature method execution, but this can be changed using `mode` to | |||
| also run setup and cleanup on retries. Even in this mode, the retry is only triggered if the feature method is failing | |||
There was a problem hiding this comment.
@leonard84 is this actually the intended and expected behavior?
That only expected failures in the feature method trigger a retry I mean.
I do some UI tests using Geb with Marathon driver and it happens sometimes on GHA that the application cannot be started and thus the driver throws an exception.
This is done in an iteration interceptor before calling proceed, the iteration interceptor is within the retry iteration interceptor due to using global retry extension. But as the error happens there and not during feature method invocation, it does not cause a retry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.