Skip to content

IDX Cluster Fixing and Feature extension #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

schneewe
Copy link
Contributor

Due to current circumstances I wanted to use the IDX Cluster configuration playbook and therefor I have some changes.
Adding multisite option (new variables, extended tasks)
Fixed the searchhead configuration task and added to example playbook
Fixed Version check for splunk to use the right commands

@schneewe
Copy link
Contributor Author

In future maybe I would add a pre check if something changed in the variables and run the tasks only then, but I don't know if it is necessary as this is only called by specific playbook, hence it is an intended call and will be called at init or maybe if the pass4SymmKey changes

@jewnix
Copy link
Collaborator

jewnix commented Jun 20, 2023

@schneewe Seems like you didn't merge the latest changes from the upstream before you created the PR.

splunkd_port: 8089 # If changed, will overwrite the default port number used by splunkd
git_local_clone_path: ~/ # Base directory under which repositories for app deplyoment should be cloned to
git_server: undefined # e.g. ssh://git@mygithost:1234 - Note that this may be set in an all.yml group_var or inside the git_apps dictionary within host_vars
git_key: undefined # Path to SSH key for cloning repositories - Note that this may be set in an all.yml group_var or inside the git_apps dictionary within host_vars
git_key: ~ # Path to SSH key for cloning repositories - Note that this may be set in an all.yml group_var or inside the git_apps dictionary within host_vars
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used here

git_project: undefined
git_version: master # Configure default version to clone, overridable inside the git_apps dictionary within host_vars
splunk_app_deploy_path: etc/apps # Path under $SPLUNK_HOME/ to deploy apps to - Note that this may be set in group_vars, host_vars, playbook vars, or inside the git_apps dictionary within host_vars
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if changing it from undefined breaks anything, but it's being set here and in the group_vars

splunk_server_sslVersions: tls1.2
splunk_web_sslVersions: tls1.2
splunk_webserver_port: 8000
splunk_licenses: []
Copy link
Collaborator

@jewnix jewnix Jun 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a different variable for this here

Also, the splunk_server_sslVersions, splunk_web_sslVersions, splunk_webserver_port are not used anywhere.
There are several other variable added in the PR that are not being used by any playbook

Copy link
Collaborator

@jewnix jewnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a lot of work.

@@ -13,11 +13,19 @@ splunk_package_url_uf: "https://download.splunk.com/products/universalforwarder/
splunk_download_local: true # This defines how the download process works. If `true` it will download to localhost and copy around to hosts from there. If `false` each host will download the package individually.
splunk_install_type: undefined # There are two ways to configure this. The easiest way is to nest hosts under either a "full" group or a "uf" group in your inventory and main.yml will handle it for you. Or, you can also set the value via a group_vars or host_vars file.
splunk_install_path: /opt # Base directory on the operating system to which splunk should be installed
splunk_file_type: tgz # Default is a tgz installer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used anywhere


- name: Setting site affinity of cluster manager if not set
set_fact:
site_affinity: "{% if splunk_idxc_multisite and splunk_idxc_site_affinity == 'site0' %}site1{% else %}{{ splunk_idxc_site_affinity }}{% endif %}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site0 is only available on search-heads or forwarders with indexer discovery

@@ -21,3 +21,10 @@
- ../roles/splunk
vars:
- deployment_task: configure_idxc_member.yml

- hosts:
- search
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add search here

@@ -42,21 +51,28 @@ splunk_force_kill: False
systemd_unit_full: Splunkd # You can change this in `host_vars` or `group_vars` to customize the service name.
systemd_unit_uf: SplunkForwarder # You can change this in `host_vars` or `group_vars` to customize the service name.
splunk_disable_mgmt_port: false # If set to true, will disable splunkd management port during installation
splunk_mgmt_uri: "{{ ansible_fqdn }}" # If the `ansible_fqdn` is not resolvable by other hosts, you can set it to something like `ansible_facts.default_ipv4.address` in `host_vars` or `group_vars` to use the IP address instead.
splunk_disable_kvstore: false # If set to true, will disable the kvstore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where this is being used

@schneewe
Copy link
Contributor Author

Yeah I see, you are right, there was a different base used, I will create a complete new one.

@schneewe
Copy link
Contributor Author

schneewe commented Jul 3, 2023

I created a new PR #195

@schneewe schneewe closed this Jul 3, 2023
@schneewe schneewe deleted the idx_cluster_feat branch July 3, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants