Skip to content
This repository was archived by the owner on Oct 2, 2025. It is now read-only.

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 11, 2024

This is a fix for #6979.

ipv6

The IPv6 checkbox was previously checked when it should not have been.

This line:

associateIPv6Address: shouldAutoEnableIPv6 || Boolean(ipv6AddressCount),

Was casting the entire object below to Boolean, which ALWAYS resulted in a value of true:

[
  {
    "deviceIndex": 0,
    "groups": [
      "sg-0a1a8a45acf3192b8"
    ],
    "ipv4Prefixes": [],
    "ipv6AddressCount": 0,
    "ipv6Addresses": [],
    "ipv6Prefixes": [],
    "privateIpAddresses": []
  }
]

The change casts the value of ipv6AddressCount within the object to Boolean instead of the object itself.


This is an automatic backport of pull request #10142 done by Mergify.

…g server groups that have launch templates enabled (#6979) (#10142)

(cherry picked from commit 22818c6)
@dbyron-sf dbyron-sf added the ready to merge Reviewed and ready for merge label Sep 11, 2024
@mergify mergify bot added the auto merged Merged automatically by a bot label Sep 11, 2024
@mergify mergify bot merged commit d2e3a0c into release-1.35.x Sep 11, 2024
4 checks passed
@mergify mergify bot deleted the mergify/bp/release-1.35.x/pr-10142 branch September 11, 2024 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

auto merged Merged automatically by a bot ready to merge Reviewed and ready for merge target-release/1.35

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants