-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[docs] Add Github repo icon-link to topbar #12462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @timhoffm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we have this already with the RTD widget? do you want to duplicate it? Personally, I'd prefer having it in the footer rather at the top (it's a bit less intruisive)
I'm afraid I must vehemently disagree here; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'm in.
Thanks 😄 and BTW thanks for all the quick reviews, let me know if you have any PRs outstanding I should be looking at! |
Thanks, this is an improvement. 👍 As a feedback, I've been looking for a GitHub link from inside the docs multiple times. It was something like "Contribute -> Contribute Code -> Find a link somewhere in a paragraph of text". |
No problem! the only PR that is still waiting for rewiew is #12219 but this is a huge one. If you have a bit of time, then I don't mind. Most of my ongoing PRs are in CPython currently. |
Add a link to https://github.com/sphinx-doc/sphinx, via an icon on the right of the topbar
https://sphinx--12462.org.readthedocs.build/en/12462/