Skip to content

Conversation

@saschagrunert
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/docs-generation Generation of docs via Cobra label Sep 4, 2025
@saschagrunert
Copy link
Author

Ah this is already done by #2278

@saschagrunert saschagrunert deleted the yaml branch September 4, 2025 09:48
@ccoVeille
Copy link
Contributor

ccoVeille commented Sep 4, 2025

Yes, and no.

#2278 is about moving to use goccy-yaml which could lead to problems

#2277 is about using a maintained version of a yaml lib.

Your PR is great as it migrates to https://github.com/yaml/go-yaml via go.yaml.in/yaml/v4

This version is supported by the YAML organization.

But for now, I would prefer you to use go.yaml.in/yaml/v3 with v3.0.4

So please reopen the PR

@saschagrunert saschagrunert restored the yaml branch September 4, 2025 11:56
@saschagrunert saschagrunert reopened this Sep 4, 2025
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Author

@ccoVeille done, please take another look.

@marckhouzam
Copy link
Collaborator

Thanks @saschagrunert . You will need to sign the CLA: #2306 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs-generation Generation of docs via Cobra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants