Skip to content

fix: Check for bool flag in stripFlags (#2251) #2263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Check for bool flag in stripFlags (#2251) #2263

wants to merge 1 commit into from
+65 −13

Conversation

@parametalol
Copy link

A try to fix #2251.

  • Removed the call to mergePersistentFlags in favor of just collecting all flags, including the ones from the children;
  • Refactored stripFlags;
  • Had to reimplement flag.AddFlagSet to check for shorthands.

Tested with unit tests.

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@parametalol parametalol marked this pull request as ready for review April 17, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistent parsing of boolean flags between parent and child commands

2 participants

@parametalol @CLAassistant