initial support bolt12 offers #10110
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f321x
reviewed
Oct 6, 2025
ecdsa
reviewed
Oct 6, 2025
| final_cltv_abs=final_cltv_abs, | ||
| total_msat=total_msat, | ||
| bolt12_invoice=bolt12_invoice) | ||
|
|
There was a problem hiding this comment.
bolt12_invoice could be an optional arg
ecdsa
reviewed
Oct 6, 2025
| self.payment_key = payment_hash + payment_secret | ||
| Logger.__init__(self) | ||
|
|
||
| self.bolt12_invoice = bolt12_invoice |
ecdsa
reviewed
Oct 6, 2025
| """ | ||
| erd_key = 'encrypted_data' # used in 'payload' TLV | ||
| if tlv_stream_name == 'onionmsg_tlv': # used in 'onionmsg_tlv' TLV | ||
| erd_key = 'encrypted_recipient_data' |
accumulator
force-pushed
the
bolt12
branch
4 times, most recently
from
92419fc to
59a86cd
Compare
…ation and schnorr-sign over tlvs, implicit en/decode utf8 fields, schnorr signature verification.
…ce_error reply message
…ice field, due to inflexibility of adding fields to @attr.s objects making it hard to use wallets between branches. TODO: determine final place for bolt12 invoice data in Invoice
add lnonion.calc_hops_data_for_blinded_payment, initial support for routing to blinded paths in lnpeer, lnworker
…ply_paths. the former also calculates payinfo information for payment scenarios.
- offers are not saved and only kept in memory, so only for testing
- offer_paths are taken from the active channels with peers supporting onion messages
- only the first channel is included in offer_paths, with the peer as the introduction point
of the blinded path
- the offer key is the same as path_id used in the blinded path
- expiry is included in the offer but ignored elsewhere
|
I have pushed a new version of https://github.com/spesmilo/electrum/commits/test_blinded_payment_onion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains initial support for BOLT12
offerpayment identifiers,invoiceby sendinginvoice_requestvia onion messageinvoiceandinvoice_errorresponsesinvoicebolt11data structures likeLnAddr, to minimize changes in payment sending code pathinvoicecurrently stored inInvoice.lightning_invoicewith a prefix, because adding a new field to an@attr.sobject is a PITA when switching branches, final storage location TBD.notes w.r.t current state:
offer_pathinofferis queried, iteration of multipleoffer_pathis TODOpathininvoice_pathsis tried, iteration of multiplepathis TODOinvoicehas no blinded path (introduction point == destination) succeedinvoicehas blinded path w. >=2 hops fail when testing against CLN, non-final hop however does resolve the next hop, but next hop errors with a invalid HMAC error.calc_hops_data_for_blinded_paymentis not computing per-hop fee/amount/cltv values for blinded hops correctly yet.