Preserve links when markup is being truncated/linebroken #1813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #363
Changes
This doesn't fix the ID issues talked about in the original issue, only the link target being incorrect when the segment is split over multiple lines or truncated and the link is to be generated via the text e.g.
[link]https://example.com[/]
.Attempting to share a link ID over these portions makes things much more complex and the end result is just that the link will have a correct hover effect on some terminals. This could be addressed in a separate change.
Please upvote 👍 this pull request if you are interested in it.