Skip to content

Preserve links when markup is being truncated/linebroken #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShaunLawrie
Copy link

fixes #363

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

This doesn't fix the ID issues talked about in the original issue, only the link target being incorrect when the segment is split over multiple lines or truncated and the link is to be generated via the text e.g. [link]https://example.com[/].

Attempting to share a link ID over these portions makes things much more complex and the end result is just that the link will have a correct hover effect on some terminals. This could be addressed in a separate change.


Please upvote 👍 this pull request if you are interested in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links (id and target) do not survive the render process
1 participant