-
Notifications
You must be signed in to change notification settings - Fork 8
fix: improved unmarshalling and validation errors of eithervalues #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a087cb to
1d0d3fa
Compare
📊 Test Coverage ReportCurrent Coverage: Coverage Change: ✅ No change Coverage by Package
Generated by GitHub Actions |
BlakeTheAwesome
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
marshalling
Related to data marshalling/unmarshalling
tests
Test-related changes and improvements
validation
Related to validation logic
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improved unmarshalling and validation error messages for
EitherValuetypes to make it easier to identify the root cause of failures.Changes
EitherValueunmarshalling: Updated error messages to provide clearer information about which type alternatives failed and whyImpact
This change improves the developer experience when working with
EitherValuetypes by:Testing
values/core/eithervalue_test.gomarshaller/unmarshalling_test.goopenapi/openapi_examples_test.go