Skip to content

849-replace-underscore-with-dash-package-manager #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mneumei
Copy link

@mneumei mneumei commented May 14, 2025

Resolves the issue 849 to comply with the spdx.2.3 standard where PACKAGE_MANAGER is replaced by PACKAGE-MANAGER

@mneumei
Copy link
Author

mneumei commented May 14, 2025

@meretp ,would you be so kind to review my pr?

Signed-off-by: Michael Neumeier <Michael.Neumeier@de.bosch.com>
@mneumei mneumei force-pushed the 849-replace-underscore-with-dash-package-manager branch from c821316 to d5a3b6e Compare May 14, 2025 17:53
Copy link
Collaborator

@meretp meretp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its not that easy, the spec also allows for underscore in JSON/YAML/XML format so we decided to only write underscore.

@mneumei
Copy link
Author

mneumei commented May 16, 2025

@meretp, i have a similar issue as @billie-alsup, where the reader will go strictly for the spec, and only allow for dashes. In #793 there were also comments that the default should meet the spec. Would it be more helpful to make it selectable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants