Moved the metadata into setup.cfg.

[KOLANICH]

Added pyproject.toml.
Renamed console_scripts because their names are too generic to have this package installed into system.
Versions are now fetched from git tags.

[pombredanne]

Thanks! See my comments inline for you review.

[pombredanne]

@KOLANICH can you also add your DCO signoff? This was an informal requirement which was not consistently applied until now... this way I can then merge.

[pombredanne]

This has been merged after a rebase.
Thanks!

[pombredanne]

Fat fingers!
Not merged yet. Sorry for the noise

[armintaenzertng]

@KOLANICH, do you still plan to address these change requests?

@pombredanne, are these changes still up-to-date?

[pombredanne]

@pombredanne, are these changes still up-to-date?

I think they are... but your call to verify this.

[armintaenzertng]

Thanks @KOLANICH for updating this! :)

Removing setup.py seems like a breaking change, though, and CircleCI workflows also depend on it. I think keeping a minimal setup.py as Philippe suggested here would be the best option for now.

[armintaenzertng]

Thanks for the update, @KOLANICH!
CircleCI is still broken, though. Do you plan to look into this?

[armintaenzertng]

@pombredanne, this still has a blocker from you, would you mind to revisit/lift this? :)

[KOLANICH]

just noting this is not mentioned at as belonging in project table at https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#setuptools-specific-configuration

That doc mentions only setuptools-specific configuration. The most of pyproject.toml is the standardized one for all the major backends except poetry according to PEP 621.

And if we're renaming these, which IMO is a good idea as these names are too generic, can we please change "convertor" to "converter" in order to be using the main word in the dictionaries.

To be honest, convertor feels better for me and I guess for people too: searching in Bing (Google doesn't give out this info at least when JS is disabled) reveals:
convertor 566 000 000 results
converter 564 000 000 results

The rest of suggestions are implemented, thanks.

[jayvdb]

There are still many other mentions of the CLI command names inside the codebase.

pdx/cli_tools/convertor.py:        ' convertor ---infile <input_file> ---outfile <output_file>.
spdx/cli_tools/convertor.py:        ' convertor -f/--from <type> <input_file> -t/--to <type> <output_file>.
spdx/cli_tools/convertor.py:        ' convertor -f/--from <type> <input_file> --outfile <output_file> '
spdx/cli_tools/convertor.py:        ' convertor --infile <input_file> -t/--to <type> <output_file>'
spdx/cli_tools/convertor.py:        raise ValueError("Given arguments for convertor are invalid.")
spdx/cli_tools/convertor.py:    To use : run 'convertor -f <from_TYPE> <input file> -t <to_TYPE> <output_file>' command on terminal or use ' convertor --infile <input file name> --outfile <output file name> '

[nicoweidner]

Thanks for updating the setup scripts! I won't be able to merge until the appveyor issue is resolved, though...

@pombredanne Anything missing in your opinion? You are still set to "changes requested".

Asked for another opinion a while ago; reviewer stated (basically) that he won't be involved in a further review process in #156 (comment)

[nicoweidner]

Thanks for rebasing again, @KOLANICH! I will go ahead and merge this before new conflicts arise

[nicoweidner]

Didn't know about this, pretty cool!
In case anyone else stumbles across this: https://pypi.org/project/setuptools-scm/, look for "Default versioning scheme"

[jayvdb]

Please see #362